10111c87cf3e85ab2fe331835c0b3d6c8bb31947,src/python/pants/backend/graph_info/tasks/minimal_cover.py,MinimalCover,_collect_internal_deps,#MinimalCover#Any#,29

Before Change



  def _collect_internal_deps(self, target):
    internal_deps = set()
    target.walk(internal_deps.add)
    internal_deps.discard(target)
    return internal_deps

After Change


    resulting set will not include the roots unless the roots depend on one another.
    
    roots = set()
    for target in targets:
      roots.update(target.dependencies)
    return Target.closure_for_targets(roots)
Italian Trulli
In pattern: SUPERPATTERN

Frequency: 3

Non-data size: 4

Instances


Project Name: pantsbuild/pants
Commit Name: 10111c87cf3e85ab2fe331835c0b3d6c8bb31947
Time: 2017-04-12
Author: stuhood@twitter.com
File Name: src/python/pants/backend/graph_info/tasks/minimal_cover.py
Class Name: MinimalCover
Method Name: _collect_internal_deps


Project Name: pantsbuild/pants
Commit Name: 7699c5dcdb3cfbb8050581aed2f2eb7a5cc99579
Time: 2014-08-08
Author: garrett.malmquist@gmail.com
File Name: src/python/pants/backend/codegen/tasks/protobuf_gen.py
Class Name: ProtobufGen
Method Name: _calculate_sources


Project Name: pantsbuild/pants
Commit Name: 7699c5dcdb3cfbb8050581aed2f2eb7a5cc99579
Time: 2014-08-08
Author: garrett.malmquist@gmail.com
File Name: src/python/pants/backend/codegen/targets/java_protobuf_library.py
Class Name: JavaProtobufLibrary
Method Name: imports