d03c17c40a2f3874c6b901d75763dcfc1492955c,workers/data_refinery_workers/processors/no_op.py,,_no_op_processor_fn,#Any#,13

Before Change

        job_context["success"] = False
        return job_context

    try:
        file.remove_raw_files()
    except:
        // If we fail to remove the raw files, the job is still done
        // enough to call a success. However logging will be important
        // so the problem can be identified and the raw files cleaned up.
        logger.exception("Exception caught while removing raw file %s",
                         raw_path,
                         batch=file.batch.id,
                         processor_job=job_context["job_id"])

    job_context["success"] = True
    return job_context

After Change

    // Create a ComputedFile for the sample,
    // sync it S3 and save it.
    try:
        computed_file = ComputedFile()
        computed_file.absolute_file_path = sample.source_absolute_file_path
        computed_file.filename = sample.source_filename
        computed_file.calculate_sha1()
        computed_file.calculate_size()
        computed_file.result = result
        computed_file.sync_to_s3(S3_BUCKET_NAME, computed_file.sha1 + "_" + computed_file.filename)
        // TODO here: delete local file after S3 sync
        computed_file.save()
    except Exception:
        logger.exception("Exception caught while moving file %s",
                         raw_path,
                         processor_job=job_context["job_id"])

Instances