ed213612f72a23c3a87bf8d8cbae858c41c26e10,nalaf/features/relations/new/sentence.py,SentenceFeatureGenerator,generate,#SentenceFeatureGenerator#,40

Before Change

            for e_class_id, entities in edge.get_any_entities_in_sentences(predicted=False).items():
                count = len(entities)
                if e_class_id in [edge.entity1.class_id, edge.entity2.class_id]:
                    // Rest -1 thus removing each consider pair of entities
                    count -= 1

                // TODO feature select with integer value or binary representation ?
                // self.add(f_set, is_train, edge, "f_counts", "binary", e_class_id, "is", count)
                self.add_with_value(f_set, is_train, edge, "f_counts", count, "int", e_class_id)

            for e_class_id, entities in edge.get_any_entities_between_entities(predicted=False).items():
                count = str(len(entities))

After Change

            for e_class_id, entities in edge.get_any_entities_in_sentences(predicted=False).items():
                count = -1  // start from -1, as one is already one of the edge"s entities
                count += len(entities)
                assert count >= 0
                self.add_with_value(f_set, is_train, edge, "f_counts", count, "int", e_class_id)

            count = 0
            for e_class_id, entities in edge.get_any_entities_between_entities(predicted=False).items():

Instances