ef7964296ee8d5025dbdf7ca02eddd72a8b9df56,src/python/pants/backend/codegen/protobuf/protoc.py,Protoc,generate_url,#Protoc#,39

Before Change

    def generate_url(self, plat: Platform) -> str:
        version = self.get_options().version
        if version in {"2.4.1", "2.5.0", "2.6.1"}:
            // Very old versions of protoc don"t have binaries available in their github releases.
            // So for now we rely on the pants-hosted binaries.
            // TODO: Get rid of or update our tests that rely on this very old version.
            //  Then we can consider whether to stop supporting it.
            if plat == Platform.darwin:
                plat_str = "mac/10.13"
            elif plat == Platform.linux:
                plat_str = "linux/x86_64"
            else:
                raise ExternalToolError()
            return f"https://binaries.pantsbuild.org/bin/protoc/{plat_str}/{version}/protoc"

        if plat == Platform.darwin:
            plat_str = "osx"
        elif plat == Platform.linux:
            plat_str = "linux"

After Change

    def generate_url(self, plat: Platform) -> str:
        version = self.options.version
        plat_str = match(plat, {Platform.darwin: "osx", Platform.linux: "linux"})
        return (
            f"https://github.com/protocolbuffers/protobuf/releases/download/"
            f"v{version}/protoc-{version}-{plat_str}-x86_64.zip"

Instances