c1c5544326a7e2eb080101cf2ca29707b5e41736,lib/python/cellranger/rna/feature_ref.py,,parse_feature_def_file,#,300

Before Change

            if "\t" in row["name"]:
                raise FeatureDefException("Feature name field cannot contain tabs: "%s"" % row["name"])

            if " " in row["id"] or "\t" in row["id"]:
                raise FeatureDefException("Feature id field cannot contain whitespace: "%s"" % row["id"])

            // Additional columns become key-value pairs
            // Maintain input order
            tag_cols = [c for c in reader.fieldnames if c not in BASE_FEATURE_FIELDS and c in row]

            tags = OrderedDict()
            for key in tag_cols:

After Change

            allowed_id_chars = set(string.printable) - set(string.whitespace) - set("/,\""\\`")

            for (idx, c) in enumerate(row["id"]):
                if not c in allowed_id_chars:
                    if c in string.whitespace:
                        raise FeatureDefException(u"Feature id field cannot contain whitespace: "%s"" % row["id"])
                    else:
                        msg = "Feature id field contains an illegal character at position %d: "%s"" % (idx, row["id"])
                        msg += "\nFeature IDs may only ASCII characters, and must not use whitespace slash, quote or comma characters."
                        raise FeatureDefException(msg)

            // Additional columns become key-value pairs
            // Maintain input order
            tag_cols = [c for c in reader.fieldnames if c not in BASE_FEATURE_FIELDS and c in row]

            tags = OrderedDict()
            for key in tag_cols:

Instances