3e6b2db90f08a226f751f706ac0f6eb1d487de1b,pgmpy/models/FactorGraph.py,FactorGraph,check_model,#FactorGraph#,166

Before Change

            raise ValueError("Factors not associated for all the random"
                             "variables.")

        factor_nodes = set(self.nodes()) - set(variable_nodes)
        if len(factor_nodes) != len(self.factors):
            raise ValueError("Factors not associated with all the factor nodes.")

        cardinalities = self.get_cardinality()

After Change

        variable_nodes = set([x for factor in self.factors for x in factor.scope()])
        factor_nodes = set(self.nodes()) - variable_nodes

        if not all(isinstance(factor_node, Factor) for factor_node in factor_nodes):
            raise ValueError("Factors not associated for all the random variables")

        if (not (bipartite.is_bipartite(self)) or 
           not (bipartite.is_bipartite_node_set(self, variable_nodes) or 
                bipartite.is_bipartite_node_set(self, variable_nodes))):
            raise ValueError("Edges can only be between variables and factors")

Instances